Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize gas estimation #47

Closed
akru opened this issue Nov 28, 2018 · 0 comments
Closed

Optimize gas estimation #47

akru opened this issue Nov 28, 2018 · 0 comments
Labels
enhancement
Milestone
Release 1.0-rc1

Comments

@akru
Copy link
Member

akru commented Nov 28, 2018 •
edited
Loading

The Problem

Currently gas estimation isn't so effective. Moving gas estimation to Lighthouse contract can be more effective because it closer to transaction entry point in most cases.

Changes

  • Lighthouse: added startGasEstimation modifier
  • LiabilityFactory: added endGasEstimation modifier
  • LiabilityFactory: added liabilityCreated and liabilityFinalized hooks for gas accounting
  • LiabilityFactory: gasUtilizing -> gasConsumed

Affected
@akru akru added this to the Release 0.13 milestone Nov 28, 2018
akru added a commit that referenced this issue Nov 30, 2018
@akru
Robonomics generation 4 contracts
f273108 
* Added interface files, fix #49, fix #50
* Added KYC for ambix and auction, fix #48
* Optimized gas estimation, fix #47
* Migrated to new truffle version, fix #46
* Moved ENS contracts to contracts/ens
@akru akru closed this as completed in 3f81800 Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 1.0-rc1
Development

No branches or pull requests
1 participant
@akru