Supply permission callback #113
Conversation
|
Is this the fix for #112? |
| @@ -0,0 +1,7 @@ | |||
| package com.airbnb.android.airmapview.listeners; | |||
|
|
|||
| public interface OnLocationPermissionListener { | |||
There was a problem hiding this comment.
can you please add javadocs to this interface?
| static void onRequestPermissionsResult(AirMapInterface airMapInterface, int requestCode, | ||
| int[] grantResults) { | ||
| public static void onRequestPermissionsResult(Activity activity, AirMapInterface airMapInterface, int requestCode, | ||
| String[] permissions, int[] grantResults) { |
There was a problem hiding this comment.
revert formatting change?
| import static android.support.v4.content.PermissionChecker.checkSelfPermission; | ||
|
|
||
| /** | ||
| * Utility class that handles runtime permissions | ||
| */ | ||
| final class RuntimePermissionUtils { | ||
| public final class RuntimePermissionUtils { |
There was a problem hiding this comment.
does this need to be public?
| } | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
should use 2-space indentation instead
| return false; | ||
| } | ||
|
|
||
| final Set<String> requestPermissions = new HashSet<>(Arrays.asList(LOCATION_PERMISSIONS)); |
There was a problem hiding this comment.
you can use Collections.singleton() instead
|
@felipecsl yes, it fixes the #112 and 1 other issue about permission: setMyLocationEnabled won't work immediately even after the permission is accepted. Thank you for the comments, they are all very good, I will address them soon. |
|
Comments addressed. |
|
@felipecsl PTAL, thank you |
| return false; | ||
| } | ||
|
|
||
| final Set<String> requestPermissions = new HashSet<>(Arrays.asList(LOCATION_PERMISSIONS)); |
There was a problem hiding this comment.
it's not clear to me why you're creating this set with a single item inside?
can you just check if permission.equals(LOCATION_PERMISSIONS) on line 55?
| } else if (!shouldShowRequestPermissionRationale(activity, LOCATION_PERMISSIONS)) { | ||
| airMapInterface.onLocationPermissionsNeverAskAgain(); | ||
| } else { | ||
| airMapInterface.onLocationPermissionsDenied(); |
There was a problem hiding this comment.
indentation is still 4 spaces here
| } | ||
|
|
||
| @Override public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, | ||
| @NonNull int[] grantResults) { | ||
| @NonNull int[] grantResults) { |
Descriptions:
Supply the permission callbacks.
onCheckLocationPermissionResult, sinceonRequestPermissionsResultin NativeGoogleMapFragment and WebviewMapFragment won't be called whenrequestPermissions.Test:
Tested with Sample app
Reviewers:
@felipecsl @gpeal @nwadams