-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tvOS support #81
Merged
Merged
tvOS support #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @RomanPodymov ! If you can get the build working, then this seems like a good change! https://travis-ci.com/github/airbnb/MagazineLayout/builds/176573279 |
Done. |
bryankeller
approved these changes
Jul 30, 2020
thanks a bunch @RomanPodymov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Thank you for MagazineLayout.
In this pull request I added tvOS support.
Details
Added
appletvos
andappletvsimulator
platforms for MagazineLayout.framework.Added MagazineLayoutExampleAppleTV to test MagazineLayout.framework on tvOS.
Using
#if os(iOS)
for the iOS-only classes.Related Issue
Motivation and Context
I think it will be nice to have tvOS support for MagazineLayout.
How Has This Been Tested
I launched MagazineLayoutExampleAppleTV on Apple TV 4K simulator with tvOS 13.4.
I observed the same collection views as in MagazineLayoutExample.
Types of changes
Checklist