Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bandit security scanning to CI #100

Merged
merged 4 commits into from
Jan 10, 2018
Merged

Add Bandit security scanning to CI #100

merged 4 commits into from
Jan 10, 2018

Conversation

austinbyers
Copy link
Collaborator

@austinbyers austinbyers commented Jan 9, 2018 •
edited
Loading

to: @javuto
cc: @airbnb/binaryalert-maintainers
size: small

Background

Bandit is a Python scanner which checks for common security issues in Python source code.

Changes

  • Add Bandit to the requirements
  • Add Bandit configuration and enforce in CI
  • Update requirements

Tested

  • To run locally: bandit -r .
  • Travis CI
  • Approved by Smokey and The Bandit:

img_20170321_090059

@austinbyers austinbyers requested a review from javuto January 9, 2018 22:12
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.787% when pulling fb7d79e on austin-bandit into f8141d4 on master.

@austinbyers austinbyers mentioned this pull request Jan 9, 2018
Merged
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5ac0b11 on austin-bandit into ** on master**.

javuto
javuto approved these changes Jan 10, 2018
View reviewed changes
Copy link

@javuto javuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@austinbyers austinbyers merged commit db857f3 into master Jan 10, 2018
@austinbyers austinbyers deleted the austin-bandit branch January 10, 2018 19:21
@austinbyers austinbyers added this to the v1.2.0 milestone Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javuto javuto javuto approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@austinbyers @coveralls @javuto