Update for ESLint 3.0.0 #939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule was added by 1.10.0. I am setting it to be disabled because it is very project-specific, so it doesn't make sense to enable it here. https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-restricted-paths.md I found the sections of this file a little confusing, so I didn't know where to put it. I think it would be better to simply alphabetize the rules but I'll leave that for another time.
This rule seems to be giving me errors for some places we have imported devDependencies in our tests such as tape and eslint. This is actually okay, so we just need to configure this rule to allow devDependencies for tests. While I was at it, I added some whitespace to improve readability and reduce the likelihood of merge conflicts.
ESLint 3.0.0 was recently released. I don't see any breaking changes that affect our configuration, so it seems like we can support the currently supported range in addition to 3.0.0+. http://eslint.org/blog/2016/07/eslint-v3.0.0-released
|
❌ this is captured in #936, and has peer dep blockages. In addition, I already have this change prepared locally. |
|
Ah rats, I missed that entirely. Are my first two commits still useful? |
|
I'll definitely grab 2d38704 - the other one I've already got. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint 3.0.0 was recently released. I don't see any breaking changes
that affect our configuration, so it seems like we can support the
currently supported range in addition to 3.0.0+.
http://eslint.org/blog/2016/07/eslint-v3.0.0-released
I needed to fix a couple of minor things to get tests to pass.