Add COMPOSITION in KeyPath to target root composition layer. #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
May 10, 2020
|
@boduan-coder Can you add some javadocs? Other than that, lgtm! |
boduan-coder
changed the title
|
@gpeal , is the screenshot test automatically triggered? I can't see the test report. |
|
@boduan-coder I accidentally broke them but just fixed them here #1563 Could you merge then push to kick it off again? |
boduan-coder
force-pushed
the
bo_add_root_composition
branch
from
b34dd6e
to
a4988ad
Compare
|
@gpeal , could you please help merge this PL if everything looks good? |
|
Friendly ping :) |
gpeal
approved these changes
May 29, 2020
There was a problem hiding this comment.
Thanks for doing this @boduan-coder and sorry for the delay. I have been hard at work on MvRx 2.0 and that has been eating up all of my limited open source nights and weekends time
https://github.com/airbnb/MvRx/commits/release/2.0.0
boduan-coder
added a commit
to boduan-coder/lottie-android
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.