Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GradientColorKeyframeAnimation does not handle progress outside [0,1] #2427

Merged
merged 5 commits into from
Dec 15, 2023
Merged

GradientColorKeyframeAnimation does not handle progress outside [0,1] #2427

merged 5 commits into from
Dec 15, 2023

Conversation

brudaswen
Copy link
Contributor

@brudaswen brudaswen commented Dec 13, 2023 •
edited
Loading

@brudaswen brudaswen force-pushed the fix/issue-2426-gradient-rendering branch from 6e04e49 to 68da2ba Compare December 13, 2023 16:13
@kihaki
Copy link

kihaki commented Dec 14, 2023 •
edited
Loading

Thank you for addressing this, this is an important issue for us too 🙏🏻

@github-actions GitHub Actions
Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@brudaswen brudaswen requested a review from gpeal December 14, 2023 15:26
gpeal
gpeal reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would it be possible to create a simplified animation for testing? You can put it here and it'll automatically get added to the snapshot regression tests so it doesn't break in the future.

@brudaswen
Copy link
Contributor Author

Thanks! Would it be possible to create a simplified animation for testing? You can put it here and it'll automatically get added to the snapshot regression tests so it doesn't break in the future.

I stripped down our ultra large file to a minimum. I hope this works.

@brudaswen brudaswen requested a review from gpeal December 15, 2023 08:54
@github-actions GitHub Actions
Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal changed the title GradientColorKeyframeAnimation does not handle progress outside [0,1] GradientColorKeyframeAnimation does not handle progress outside [0,1] Dec 15, 2023
@gpeal gpeal merged commit db452ea into airbnb:master Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeal gpeal gpeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GradientColorKeyframeAnimation does not handle progress outside [0,1]
3 participants
@brudaswen @kihaki @gpeal