Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enzyme-to-json missing from peer #17

Closed
mmahalwy opened this issue Nov 18, 2019 · 3 comments
Closed

enzyme-to-json missing from peer #17

mmahalwy opened this issue Nov 18, 2019 · 3 comments

Comments

@mmahalwy
Copy link

Used here:

nimbus/packages/config-jest/enzyme.js

Line 2 in f75536a

const { createSerializer } = require('enzyme-to-json');

@milesj
Copy link
Collaborator

milesj commented Nov 18, 2019

@mmahalwy It's not a dependency (or a peer) on purpose since the Enzyme functionality is opt-in.

It's mentioned in our documentation that these deps need to be installed manually.

@milesj
Copy link
Collaborator

milesj commented Nov 20, 2019

Can maybe solve this with optionalPeerDependencies.

milesj pushed a commit that referenced this issue Dec 2, 2019
fix: Add aphrodite and enzyme as optional peer deps. [#17]
b7ea888
@milesj
Copy link
Collaborator

milesj commented Dec 2, 2019

Added as optional peers in next version.

@milesj milesj closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@milesj @mmahalwy