Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Webpack manifest plugin. #34

Merged
merged 2 commits into from
Apr 6, 2020
Merged

fix: Webpack manifest plugin. #34

merged 2 commits into from
Apr 6, 2020

Conversation

rajzik
Copy link
Contributor

@rajzik rajzik commented Apr 6, 2020 •
edited
Loading

Fix void tag which throws an error when setting to true.

Uncaught SyntaxError: Unexpected token '<'

@rajzik
Copy link
Contributor Author

rajzik commented Apr 6, 2020

I know that this is a project for airbnb, but this was bug that I needed to fix as well.

@rajzik rajzik requested a review from milesj April 6, 2020 18:48
@milesj
Copy link
Collaborator

milesj commented Apr 6, 2020

We don't allow forks but I'll merge through since the change is real minor. Thanks!

@milesj milesj merged commit d939f88 into airbnb:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayes hayes Awaiting requested review from hayes hayes is a code owner

@williaster williaster Awaiting requested review from williaster williaster is a code owner

@milesj milesj Awaiting requested review from milesj milesj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajzik @milesj