add druid client #39
Merged
add druid client #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omniduct/databases/druid.py
Outdated
| self.__druid = connect(self.host, self.port, path='/druid/v2/sql/', scheme='http') | ||
|
|
||
| def _is_connected(self): | ||
| return hasattr(self, '__druid') and self.__druid is not None |
There was a problem hiding this comment.
hasattr doesn't seem to be necessary here, given that it is explicitly set in the init method.
matthewwardrop
approved these changes
Feb 6, 2018
| logger.info('Disconnecting from Druid database ...') | ||
| try: | ||
| self.__druid.close() | ||
| except Exception: |
There was a problem hiding this comment.
Do you know what the Druid client raises if it is not connected?
There was a problem hiding this comment.
It's sometimes buggy so I'm going to leave this as is for now
druid-io/pydruid#119
omniduct/databases/druid.py
Outdated
| self.__druid = connect(self.host, self.port, path='/druid/v2/sql/', scheme='http') | ||
|
|
||
| def _is_connected(self): | ||
| return hasattr(self, '__druid') and self.__druid is not None |
There was a problem hiding this comment.
Does druid have a way to check if it is connected?
danfrankj
force-pushed
the
df_add_druid_client
branch
from
1c56b67 to
32813bb
Compare
danfrankj
force-pushed
the
df_add_druid_client
branch
from
32813bb to
3a89008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matthewwardrop Druid now supports SQL