Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android polygon holes support #1781

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Android polygon holes support #1781

merged 1 commit into from
Jan 19, 2018

Conversation

xeoh
Copy link
Contributor

@xeoh xeoh commented Nov 13, 2017

Support Android polygon holes.
Duplicated issue with #1271.

@rborn
Copy link
Collaborator

rborn commented Jan 17, 2018

@alvelig @christopherdro 🐽 what should we do with this, it seems to somehow replace #1271 which doesn't have any reply from the author.

LGTM

@alvelig
Copy link
Contributor

alvelig commented Jan 18, 2018

Docs missing, but LGTM

@rborn
Copy link
Collaborator

rborn commented Jan 18, 2018

@xeoh would you mind add docs? thnx 🤗

@xeoh
Copy link
Contributor Author

xeoh commented Jan 18, 2018

@rborn ok

@xeoh
Copy link
Contributor Author

xeoh commented Jan 19, 2018

Tell me if you want anything more on docs.

@alvelig
Copy link
Contributor

alvelig commented Jan 19, 2018

That's it, thx!

Copy link
Collaborator

@rborn rborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rborn rborn merged commit eab6ff5 into react-native-maps:master Jan 19, 2018
@alvelig alvelig removed the request for review from felipecsl January 19, 2018 13:58
bennywrong pushed a commit to spin-org/react-native-maps that referenced this pull request Jan 28, 2018
@xeoh xeoh deleted the polygon-holes branch June 20, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants