[lambda][rule] updating tests to go with previous commit and adding b…

…ack a truncate call due to aws bug
airbnb · Apr 28, 2017 · 140b654 · 140b654
1 parent cf69fd7
commit 140b654
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/stream_alert/rule_processor/pre_parsers.py b/stream_alert/rule_processor/pre_parsers.py
@@ -98,6 +98,11 @@ def read_s3_file(cls, downloaded_s3_object):
             for line in open(downloaded_s3_object, 'r'):
                 yield line.rstrip()
 
+        # aws lambda apparently does not reallocate disk space when files are
+        # removed using os.remove(), so we must truncate them before removal
+        with open(downloaded_s3_object, 'w'):
+            pass
+
         # remove the file
         os.remove(downloaded_s3_object)
         if not os.path.exists(downloaded_s3_object):

diff --git a/test/unit/test_pre_parsers.py b/test/unit/test_pre_parsers.py
@@ -63,7 +63,8 @@ def test_pre_parse_s3():
     obj = s3_resource.Object(bucket_name, key_name)
     obj.put(Body=body_value)
 
-    parsed = StreamPreParsers.pre_parse_s3(raw_record)
-    assert_equal(body_value, parsed[0])
+    s3_file = StreamPreParsers.pre_parse_s3(raw_record)
+    data = StreamPreParsers.read_s3_file(s3_file).next()
+    assert_equal(body_value, data)
 
     BOTO_MOCKER.stop()