Merge pull request #302 from airbnb/ryandeivert-metric-alarms-cli

[cli][metrics] metric alarms configurable through the cli
airbnb · Sep 11, 2017 · d3ac7f3 · d3ac7f3
2 parents d54ad1a + e427d16
commit d3ac7f3
Show file tree

Hide file tree

Showing 14 changed files with 861 additions and 65 deletions.
diff --git a/conf/clusters/prod.json b/conf/clusters/prod.json
@@ -29,6 +29,7 @@
       },
       "rule_processor": {
         "current_version": "$LATEST",
+        "enable_metrics": true,
         "log_level": "info",
         "memory": 128,
         "timeout": 10

diff --git a/conf/global.json b/conf/global.json
@@ -6,9 +6,6 @@
     "region": "us-east-1"
   },
   "infrastructure": {
-    "metrics": {
-      "enabled": true
-    },
     "monitoring": {
       "create_sns_topic": true
     }

diff --git a/docs/source/athena-deploy.rst b/docs/source/athena-deploy.rst
@@ -55,6 +55,7 @@ Open ``conf/lambda.json``, and fill in the following ``Required`` options:
 Key                                  Required  Default                Description
 -----------------------------------  --------  --------------------   -----------
 ``enabled``                          ``Yes``   ``true``               Enables/Disables the Athena Partition Refresh Lambda function
+``enable_metrics``                   ``No``    ``false``              Enables/Disables logging of metrics for the Athena Partition Refresh Lambda function
 ``log_level``                        ``No``    ``info``               The log level for the Lambda function, can be either ``info`` or ``debug``.  Debug will help with diagnosing errors with polling SQS or sending Athena queries.
 ``memory``                           ``No``    ``128``                The amount of memory (in MB) allocated to the Lambda function
 ``timeout``                          ``No``    ``60``                 The maximum duration of the Lambda function (in seconds)
@@ -70,6 +71,7 @@ Key                                  Required  Default                Descriptio
   {
     "athena_partition_refresh_config": {
       "enabled": true,
+      "enable_metrics": false,
       "log_level": "info",
       "memory": 128,
       "refresh_type": {