Merge pull request #496 from airbnb/ryandeivert-output-method-fix

[lambda][alert] fixing small bug where method should be classmethod
airbnb · Nov 21, 2017 · dc1cec8 · dc1cec8
2 parents cddd3bf + ff640c1
commit dc1cec8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/stream_alert/alert_processor/outputs/output_base.py b/stream_alert/alert_processor/outputs/output_base.py
@@ -303,7 +303,8 @@ def _get_default_properties(cls):
         """
         pass
 
-    def output_cred_name(self, descriptor):
+    @classmethod
+    def output_cred_name(cls, descriptor):
         """Formats the output name for this credential by combining the service
         and the descriptor.
 
@@ -313,7 +314,7 @@ def output_cred_name(self, descriptor):
         Returns:
             str: Formatted credential name (ie: slack_ryandchannel)
         """
-        cred_name = str(self.__service__)
+        cred_name = str(cls.__service__)
 
         # should descriptor be enforced in all rules?
         if descriptor: