[lambda][alert] adding support for sns as a source #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anotha commit |
ryandeivert
force-pushed
the
ryandeivert-sns-source-support
branch
from
cdc205e to
4c9de29
Compare
jacknagz
reviewed
Apr 25, 2017
| @@ -67,8 +67,8 @@ def validate_config(config): | |||
|
|
|||
| # check sources attributes | |||
| elif config_key == 'sources': | |||
| if not set(settings.keys()).issubset(set(['kinesis', 's3'])): | |||
| raise ConfigError('Sources missing kinesis or s3 keys') | |||
| if not set(settings.keys()).issubset(set(['kinesis', 's3', 'sns'])): | |||
There was a problem hiding this comment.
instead of doing set([]) let's just do {}
jacknagz
reviewed
Apr 25, 2017
| @@ -130,11 +130,14 @@ def map_source(self, payload): | |||
| payload.service = 'kinesis' | |||
| elif 's3' in payload.raw_record: | |||
| payload.service = 's3' | |||
| elif 'Sns' in payload.raw_record: | |||
| payload.service = 'sns' | |||
|
|
|||
| # map the entity name from a record | |||
| entity_mapper = { | |||
There was a problem hiding this comment.
#simplify (discussed offline)
ryandeivert
force-pushed
the
ryandeivert-sns-source-support
branch
from
5803ad8 to
4c9de29
Compare
Updating tests to include sns sources.
ryandeivert
force-pushed
the
ryandeivert-sns-source-support
branch
from
4c9de29 to
b6cb86b
Compare
jacknagz
reviewed
Apr 25, 2017
| @@ -86,6 +88,12 @@ def s3_process(self, payload, classifier): | |||
| classifier.classify_record(payload, data) | |||
| self.process_alerts(payload) | |||
|
|
|||
| def sns_process(self, payload, classifier): | |||
| """Process SNS data for alerts""" | |||
| data = StreamPreParsers.pre_parse_sns(payload.raw_record) | |||
There was a problem hiding this comment.
this method looks almost the same as the kinesis pre parser, can we simplify?
There was a problem hiding this comment.
I made a small change, but it just mostly consolidates duplicate code into a method. The pre_parse.. methods pull data from different keys, so this is about as simple as this get (see pre_parsers.py for more context).
ryandeivert
force-pushed
the
ryandeivert-sns-source-support
branch
2 times, most recently
from
df89c55 to
d29a645
Compare
ryandeivert
force-pushed
the
ryandeivert-sns-source-support
branch
from
d29a645 to
57bfccc
Compare
jacknagz
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to @airbnb/streamalert-maintainers
size: small
work in progress for #64
changes