Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lambda][output] updating slack output format to support large messages #135

Merged
merged 2 commits into from
May 5, 2017

Conversation

ryandeivert
Copy link
Contributor

@ryandeivert ryandeivert commented May 5, 2017

to @airbnb/streamalert-maintainers
size: medium

changes

  • Slack output will now use attachments and split the message on the Slack recommended size of 4000 characters/bytes.

  • Output will also be formatted with tabs and "markdown" styling.

  • Messages will look similar to this in Slack (with the proper App name/icon):
    image

  • Multi-part messages will have a (Part # of n) string after Record

@ryandeivert ryandeivert force-pushed the ryandeivert-make-slack-messages-pretty-again branch from 71ee325 to b0ef4c4 Compare May 5, 2017 02:56
@ryandeivert ryandeivert force-pushed the ryandeivert-make-slack-messages-pretty-again branch from 4eb7433 to 76b9cff Compare May 5, 2017 03:02
Copy link
Contributor

@jacknagz jacknagz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ryandeivert ryandeivert merged commit 48256ba into master May 5, 2017
@ryandeivert ryandeivert deleted the ryandeivert-make-slack-messages-pretty-again branch May 5, 2017 16:40
@ghost
Copy link

ghost commented May 19, 2017

Fixed #135

@ghost ghost mentioned this pull request May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants