[cli][bug] catch uninstalled terraform errors properly #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacknagz
reviewed
Jun 26, 2017
| @@ -59,6 +59,9 @@ def run_command(runner_args, **kwargs): | |||
| except subprocess.CalledProcessError as err: | |||
There was a problem hiding this comment.
can we just catch a tuple of error types and use the same CLI message?
There was a problem hiding this comment.
@jacknagz OSError does not have a cmd property - so we could, but we would lose some granularity. Doing it this way has the added bonus of knowing what command caused the OSError (see: runner_args[0])
jacknagz
approved these changes
Jun 27, 2017
ryandeivert
force-pushed
the
ryandeivert-bug-fix-200
branch
from
96014b5 to
b6ffa9e
Compare
jacknagz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to @jacknagz
cc @airbnb/streamalert-maintainers , @zbuc
resolves: #200
size: small
fix
OSErrorwhen trying to run a command that does not exist. Previously,subprocess.CalledProcessErrorwould not catch this because commands must exit cleanly with an error code for that exception to be caught. Commands that do not exist do not exit with an error code, and thus this was missed.terraform_checkfails to validate a TF install, we will now exit execution of the cli.other changes