Consolidate StreamAlerts Buckets #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 13, 2017 11:08
* terraform generate * unit testing * tf_stream_alert module update
ryandeivert
approved these changes
Jul 13, 2017
| input_mapping = { | ||
| 'input_sns_topics': 'aws-sns' | ||
| } | ||
| for tf_key, input_key in input_mapping.iteritems(): |
There was a problem hiding this comment.
Why the for loop when there is only one item? Is there chance that this will be expanded in the future with more keys?
There was a problem hiding this comment.
Is there chance that this will be expanded in the future with more keys?
Yep, that's the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to @ryandeivert
cc @airbnb/streamalert-maintainers
Background
A current issue with per-cluster S3 Alert buckets is that a rule acting across multiple environments will throw a permissions error. The reason is that a given Lambda function will try to send to another cluster's bucket, and no permission exists to allow that.
Change
Move the creation of StreamAlerts buckets out of each cluster and into a single bucket per StreamAlert setup.
Also update unit tests accordingly.
Tested
Verified in a side account with two clusters. Alerts were sending to the same bucket from multiple Lambda functions.
Important!
Before pulling this update and migrating to a unified bucket scheme, perform the following:
python stream_alert_cli.py terraform buildafter pulling updates from this repo.<prefix>.streamalerts.