Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamalert - rules - github - 5 new rules and some cleanup #428

Merged
4 commits merged into from
Oct 27, 2017
Merged

streamalert - rules - github - 5 new rules and some cleanup #428

4 commits merged into from
Oct 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2017 •
edited by ghost
Loading

to: @javuto or @ryandeivert
cc: @airbnb/streamalert-maintainers
size: medium

Background

See Changes

Changes

  • New rule: github_disable_dismiss_stale_pull_request_approvals
  • New rule: github_disable_protect_this_branch
  • New rule: github_disable_required_pull_request_reviews
  • New rule: github_disable_two_factor_requirement_user
  • New rule: github_oauth_application_create
  • Small changes (rule renaming, repro steps, description updates, ...)

Testing

StreamAlertCLI [INFO]: (54/54) Successful Tests
StreamAlertCLI [INFO]: (90/90) Alert Tests Passed

@ghost ghost force-pushed the mimeframe-streamalert-github-more-rules branch from ba88232 to 10cd3fd Compare October 27, 2017 06:34
@ghost ghost changed the title streamalert - rules - github - 4 new rules and some cleanup streamalert - rules - github - 5 new rules and some cleanup Oct 27, 2017
@ghost ghost force-pushed the mimeframe-streamalert-github-more-rules branch from 43dc996 to e26d20b Compare October 27, 2017 06:45
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.586% when pulling 4a2767e on mimeframe-streamalert-github-more-rules into 1372b2b on master.

javuto
javuto approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@javuto javuto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

office_manager

@ghost ghost merged commit f7be9e9 into master Oct 27, 2017
@ghost ghost deleted the mimeframe-streamalert-github-more-rules branch October 27, 2017 17:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @javuto