Global Alert Firehose #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunyong-lin
approved these changes
Nov 13, 2017
There was a problem hiding this comment.
- I only have one comment regarding TF code.
- For changes in
manage.py, I don't think it is necessary. I think you are trying to makemanage.pyshorter (number of lines). But I would prefer original format, breaking one line to multiple lines to have better readability. What you think?
But generally, LGTM.
| @@ -234,7 +234,7 @@ data "aws_iam_policy_document" "alert_processor_firehose" { | |||
| ] | |||
|
|
|||
| resources = [ | |||
| "${aws_kinesis_firehose_delivery_stream.stream_alerts.arn}", | |||
| "arn:aws:firehose:${var.region}:${var.account_id}:deliverystream/${var.prefix}_streamalert_alert_delivery", | |||
There was a problem hiding this comment.
Any reason to use full arn of firehose delivery stream, instead of ${aws_kinesis_firehose_delivery_stream.stream_alerts.arn}?
There was a problem hiding this comment.
That resource isn't in this module, so that interpolation isn't possible. I'd have to pass it in as a variable to this module instead, which I can do!
There was a problem hiding this comment.
You are right. Thanks for the explanation.
There was a problem hiding this comment.
I'm actually going to leave it, since we do the same thing for Athena data streams
|
@chunyong-lin we are moving towards using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @chunyong-lin
cc: @airbnb/streamalert-maintainers
size: medium
follow up: #457
Background
The Firehose to deliver alerts to S3 should not be cluster based, it should be global. See the tagged PR above for more context.
Changes
tf_stream_alert_globalsmodule to house global configuration sets. The idea with this module is to be a placeholder for any other global resources we'll need in the future. We can eventually move resources into it as well.aws-firehoseoutputs.Testing
Deployed and verified end-to-end in testing account