Cross Account CloudTrail Support, Kinesis CLI Parser #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacknagz
force-pushed
the
jacknaglieri-s3-cross-account-cloudtrail
branch
from
ab74193 to
418a26f
Compare
added 5 commits
November 20, 2017 13:35
jacknagz
force-pushed
the
jacknaglieri-s3-cross-account-cloudtrail
branch
from
418a26f to
03d254e
Compare
ryandeivert
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ryandeivert
cc: @airbnb/streamalert-maintainers
size: medium
Background
To enable cross-account delivery of CloudTrail logs via S3, you can modify a policy in an S3 bucket which allows the CloudTrail service to deliver logs into specific prefixes.
Also pushing misc changes to easily enable/disable kinesis events, fixing a bug in an S3 policy, and a small change in the monitoring Terraform module.
Changes
Testing