Rule context can be modified within rule #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandeivert
reviewed
Dec 12, 2017
| if rule.context: | ||
| rule_result = rule.rule_function(record, rule.context) | ||
| else: | ||
| rule_result = rule.rule_function(record) | ||
| except Exception: # pylint: disable=broad-except |
There was a problem hiding this comment.
@javuto I know this isn't part of your changes, but can you get rid of this except Exception: line and just have this be try: ... except: ... . This would get rid of that pylint disable message too
ryandeivert
approved these changes
Dec 12, 2017
| # process payloads | ||
| alerts = self.rules_engine.process(payload) | ||
|
|
||
| print alerts |
There was a problem hiding this comment.
Rouge print statement should be removed
| @rule(logs=['test_log_type_json_nested_with_data'], | ||
| outputs=['s3:sample_bucket'], | ||
| context={'assigned_user': 'not_set', 'assigned_policy': 'not_set2'}) | ||
| def modify_context_test(rec, context): # pylint: disable=unused-variable |
There was a problem hiding this comment.
you shouldn't need this # pylint: disable=unused-variable do you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ryandeivert @jacknagz
cc: @airbnb/streamalert-maintainers
size: small
Background
Context was added to rules to be able to extract information from the rule record and be utilized after (for example, outputs). This code makes that alteration possible and adds test for it.
Changes
Testing