Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[schema] cb watchlist.hit.binary vt connector optional keys #549

Merged
merged 1 commit into from
Jan 3, 2018
Merged

[schema] cb watchlist.hit.binary vt connector optional keys #549

merged 1 commit into from
Jan 3, 2018

Conversation

ryandeivert
Copy link
Contributor

to: @mime-frame
cc: @airbnb/streamalert-maintainers
size: small
resolves N/A

Background

Observed a failed parse for carbonblack watchlist.hit.binary log type due to missing keys related to virustotal connector.

Changes

  • Adding *_virustotalconnector keys as optional keys for this log type.
  • This also syncs some other previous changes related to other optional keys.

Testing

  • Tested internally with test event.

@ghost
Copy link

ghost commented Jan 3, 2018

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.21% when pulling daac145 on ryandeivert-cb-log-update into c0d9104 on master.

@ryandeivert ryandeivert merged commit e0f147e into master Jan 3, 2018
@ryandeivert ryandeivert added this to the 1.6.0 milestone Jan 3, 2018
@ryandeivert ryandeivert deleted the ryandeivert-cb-log-update branch January 10, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
log schemas
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryandeivert @coveralls