Import only .py files when importing rules #575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ryandeivert
cc: @airbnb/streamalert-maintainers
size: small
Background
Users should be able to have non-Python files in the
rules/
directory (e.g.README
,REVIEWERS
, etc). The current rules import logic imports all files except*.pyc
,.*
and__init__.*
. This means files likerules/README
are also imported, which causes anImportError
.Changes
*.py
files inrules/
andmatchers/
except__*
test_main.py
totest_init.py
(since it tests LOGGER during__init__.py
)Testing