Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[athena] KeyError bug fix #578

Merged
merged 1 commit into from
Jan 22, 2018
Merged

[athena] KeyError bug fix #578

merged 1 commit into from
Jan 22, 2018

Conversation

jacknagz
Copy link
Contributor

to: @austinbyers
cc: @airbnb/streamalert-maintainers
size: small
resolves #569

Background

A KeyError bug was discovered when deleting messages from the StreamAlert Athena Queue. This PR addresses the bug fix, and adds some small changes for clarity/ease of reading.

Changes

  • Update unit test to closer reflect reality
  • Fix the bug

Testing

  • Locally with unit testing and pylint
  • Deployed to a test account

@coveralls
Copy link

coveralls commented Jan 21, 2018

Coverage Status

Coverage remained the same at 95.429% when pulling 987c0f1 on jacknaglieri-sqs-fix-jan-2017 into 3e473a8 on master.

# Handle failure deletion
if resp.get('Failed'):
elif resp.get('Failed'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call - Successful may not be defined. However, both Successful and Failed can be defined, this should just be a separate if statement

@jacknagz jacknagz force-pushed the jacknaglieri-sqs-fix-jan-2017 branch from e29c034 to 987c0f1 Compare January 22, 2018 20:19
@jacknagz
Copy link
Contributor Author

@austinbyers PTAL

Copy link
Contributor

@austinbyers austinbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacknagz jacknagz merged commit 6e2a3d7 into master Jan 22, 2018
@jacknagz jacknagz deleted the jacknaglieri-sqs-fix-jan-2017 branch January 22, 2018 22:51
@jacknagz jacknagz added this to the 1.6.0 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Athena Partition Refresh KeyError on SQS Delete
3 participants