Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[output] Adding support to add notes to incidents #595

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

javuto
Copy link
Contributor

@javuto javuto commented Feb 13, 2018

to: @ryandeivert or @jacknagz
cc: @airbnb/streamalert-maintainers
size: small

Background

When creating incidents it may be helpful to add a note with a bit of context of what has happened or an action taken. This adds support for creating a note to a given incident.

This is just adding the functionality and the unit tests, there will be an upcoming PR to add this to the pagerduty-incidents output.

Changes

  • Added ability to create a text note given an incident id.
  • Added unit tests for the code.

Testing

$ rm .coverage && ./tests/scripts/unit_tests.sh
...
----------------------------------------------------------------------
Ran 533 tests in 9.331s

OK

$ ./tests/scripts/pylint.sh

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

$ python manage.py lambda test --processor rule all
...
StreamAlertCLI [INFO]: (60/60) Successful Tests
StreamAlertCLI [INFO]: (93/93) Alert Tests Passed
StreamAlertCLI [INFO]: Completed

@javuto javuto added this to the 1.6.1 milestone Feb 13, 2018
@coveralls
Copy link

coveralls commented Feb 13, 2018

Coverage Status

Coverage increased (+0.02%) to 95.488% when pulling 206fd8e on javier-streamalert-pagerduty-note into d508896 on master.

Copy link
Contributor

@jacknagz jacknagz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@javuto javuto force-pushed the javier-streamalert-pagerduty-note branch from f625372 to 206fd8e Compare February 14, 2018 21:57
@jacknagz jacknagz merged commit e1ecf3c into master Feb 14, 2018
@jacknagz jacknagz deleted the javier-streamalert-pagerduty-note branch February 14, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants