[athena] fix TypeError while delete messages from SQS #598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @jacknagz or @ryandeivert
cc: @airbnb/streamalert-maintainers
size: small
resolves #590
Background
We noticed there is Athena error due to
TypeError
while deleting messages from SQS. The root cause ofTypeError
is because of complicated list comprehension logic when first deletion failed. The list comprehension added extra list around pushed back messages.Changes
max_retries
in backoff logic to make the code testable.Testing