Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli][tf] lambda tf module generation now expects the lambda config from caller #664

Merged
merged 1 commit into from
Mar 29, 2018
Merged

[cli][tf] lambda tf module generation now expects the lambda config from caller #664

merged 1 commit into from
Mar 29, 2018

Conversation

ryandeivert
Copy link
Contributor

to: @austinbyers
cc: @airbnb/streamalert-maintainers
size: small

Background

Due to lambda configs living in different places in the conf directory, support is needs for accepting a lambda config from arbitrary places.

Changes

  • tf_lambda module generation now expects the lambda config to be passed from the caller

Testing

Updating unit tests for how this affects the description for the function

@coveralls
Copy link

coveralls commented Mar 29, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 95.652% when pulling bcb7b0e on ryandeivert-tf-lambda-generation into 42e93f3 on master.

@ryandeivert ryandeivert force-pushed the ryandeivert-tf-lambda-generation branch from 55afe2e to bcb7b0e Compare March 29, 2018 21:48
austinbyers
austinbyers approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@austinbyers austinbyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this way better than what I was originally doing. Thanks for the fix!

@ryandeivert ryandeivert merged commit 76b838c into master Mar 29, 2018
@ryandeivert ryandeivert deleted the ryandeivert-tf-lambda-generation branch March 29, 2018 21:58
@austinbyers austinbyers mentioned this pull request Mar 30, 2018
Merged
@ryandeivert ryandeivert added this to the 2.0.0 milestone Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinbyers austinbyers austinbyers approved these changes

Assignees
No one assigned
Labels
cli terraform
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryandeivert @coveralls @austinbyers