adding connect and read timeouts for firehose client #736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @jacknagz or @chunyong-lin
cc: @airbnb/streamalert-maintainers
size: small
resolves: #478
Background
The vast majority of our lambda execution time is spent trying to send data to firehose via boto3. This can cause timeouts, etc. The AWS kinesis team suggested shortening the connect and read timeouts to cause retries to happen faster. It's our understanding that if the connect or read takes anything over a few seconds, it's likely not going to succeed at all. Therefore, it's advantageous to just have the attempt killed at retried sooner.
Changes
FailedPutCount
values that are greater than 0.