Merge pull request #271 from sto3psl/text-em

fix: tickLabelProps dy and dx work again
airbnb · Apr 19, 2018 · 772ccea · 772ccea
2 parents 6c97c49 + 95186b1
commit 772ccea
Showing 1 changed file with 17 additions and 17 deletions.
diff --git a/packages/vx-text/src/Text.js b/packages/vx-text/src/Text.js
@@ -103,8 +103,8 @@ class Text extends Component {
     } = this.props;
     const { wordsByLines } = this.state;
 
-    const x = textProps.x + dx;
-    const y = textProps.y + dy;
+    const x = textProps.x;
+    const y = textProps.y;
 
     let startDy;
     switch (verticalAnchor) {
@@ -138,22 +138,22 @@ class Text extends Component {
     }
 
     return (
-      <text
-        x={x}
-        y={y}
-        textAnchor={textAnchor}
-        {...textProps}
-      >
-        {
-        wordsByLines.map((line, index) => (
-          <tspan x={x} dy={index === 0 ? startDy : lineHeight} key={index}>
-            {line.words.join(' ')}
-          </tspan>
-        ))
-      }
-      </text>
+      <svg x={dx} y={dy} fontSize={textProps.fontSize} style={{ overflow: 'visible' }}>
+        <text
+          {...textProps}
+          textAnchor={textAnchor}
+        >
+          {
+          wordsByLines.map((line, index) => (
+            <tspan x={x} dy={index === 0 ? startDy : lineHeight} key={index}>
+              {line.words.join(' ')}
+            </tspan>
+          ))
+        }
+        </text>
+      </svg>
     );
   }
 }
 
-export default Text;
+export default Text;