fix(vx-voronoi): make polygon required to fix type

airbnb · Oct 4, 2019 · d2752ea · d2752ea
1 parent c70156c
commit d2752ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/vx-voronoi/src/components/VoronoiPolygon.tsx b/packages/vx-voronoi/src/components/VoronoiPolygon.tsx
@@ -7,17 +7,15 @@ export type VoronoiPolygonProps = {
   /** className to apply to path element. */
   className?: string;
   /** Array of coordinate arrays for the polygon (e.g., [[x,y], [x1,y1], ...]), used to generate polygon path. */
-  polygon?: [number, number][];
+  polygon: [number, number][];
 };
 
 export default function VoronoiPolygon({
-  polygon = [],
+  polygon,
   className,
   children,
   ...restProps
 }: VoronoiPolygonProps & Omit<React.SVGProps<SVGPathElement>, keyof VoronoiPolygonProps>) {
-  if (polygon.length === 0) return null;
-
   const path = `M${polygon.join('L')}Z`;
   if (children) return <>{children({ path, polygon })}</>;
 

diff --git a/packages/vx-voronoi/test/VoronoiPolygon.test.tsx b/packages/vx-voronoi/test/VoronoiPolygon.test.tsx
@@ -12,9 +12,9 @@ describe('<VoronoiPolygon />', () => {
     expect(VoronoiPolygon).toBeDefined();
   });
 
-  test('it should not render without a polygon', () => {
-    const wrapper = shallow(<VoronoiPolygon />);
-    expect(wrapper.type()).toBeNull();
+  test('it should require a polygon prop', () => {
+    // @ts-ignore allow invalid props
+    expect(() => shallow(<VoronoiPolygon />)).toThrow();
   });
 
   test('it should render a path', () => {