Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal(workflows/release): add next dist-tag, fix lerna releases #1107

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Mar 13, 2021

🏠 Internal

This attempts to fix a couple issues with the github actions push release workflow:

  • Specifies a --dist-tag for lerna releases. Currently this is always latest, which we don't want for alpha releases since it would make the alpha pre-release the default download
  • Currently lerna is bumping/releasing all packages for each release, even if packages have not changed. I found this issue with a tip for why this happens, hoping it'll clear it up.
    • tl;dr actions/checkout@v2 only fetches the most recent commits by default, which makes lerna think it needs to publish all packages because it doesn't have the context of previous releases

Issue before
image

@kristw @hshoff

@williaster williaster merged commit f6a134c into master Mar 14, 2021
@williaster williaster deleted the chris--fix-release-workflow branch March 14, 2021 20:14
@github-actions
Copy link

🎉 This PR is included in version v1.7.1-alpha.0 of the packages modified 🎉

@github-actions
Copy link

🎉 This PR is included in version v1.7.1 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants