Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal(workflows/release): add next dist-tag, fix lerna releases #1107

Merged
merged 2 commits into from
Mar 14, 2021
Merged

internal(workflows/release): add next dist-tag, fix lerna releases #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e921be8
fix(scripts/performRelease/performLernaRelease): specify --dist-tag f…
williaster Mar 13, 2021
d1190b2
fix(workflows/push): fetch all repo commits to fix lerna release
williaster Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2 # checkout visx + this commit
with:
# pulls all commits (needed for lerna to correctly release only changed packages)
fetch-depth: '0'
- uses: actions/setup-node@v2
with:
node-version: '12'
Expand Down
5 changes: 4 additions & 1 deletion scripts/performRelease/performLernaRelease.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,13 @@ export default async function performLernaRelease(prsSinceLastTag: PR[]) {
isMajor ? 'major' : isMinor ? 'minor' : 'patch'
}`;

const distTag = isPreRelease ? 'next' : 'latest';

console.log(`Attempting to publish a '${version}' release.`);

const { stdout, stderr } = await exec(
`npx lerna publish ${version} --exact --yes --no-verify-access`,
// --no-verify-access is needed because the CI token isn't valid for that endpoint
`npx lerna publish ${version} --exact --yes --no-verify-access --dist-tag ${distTag}`,
);
if (stdout) {
console.log('Lerna output', stdout);
Expand Down