fix(xychart): include zero in scale domains by default #1008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This fixes a default behavior issue with
XYChart
scales, where their domains don't includezero
by default if the scale allows. Includingzero
in the axis domain is generally best practice, and users can still opt out by settingx/yScaleConfig={{ zero: false }}
.Before
This
AreaSeries
has 3 y-values which are all equal and non-zero. It renders like this because the y-domain is[100, 100]
. This was also reported in #1003After
With the same data + chart config, the y-domain is now
[0, 100]
.Verified it works for negative values, and horizontal orientation.
🚀 Enhancements
scaleCanBeZeroed
typeguard util to@visx/scale
(needed for typing these changes)DataProvider
'shorizontal
prop inXYChart
(noticed a small TODO during this work)@hshoff @kristw
cc @RIP21