Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(visx/visx): export @visx/xychart package #1043

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

This exports @visx/xychart from the umbrella @visx/visx. Closes #974 , supersedes #984.

Note that this export is name-spaced under the XYChart.* object because of name conflicts with other packages. For 2.0.0 we could make this consistent across all packages (e.g., @visx/annotation exported under the Axis object)

// XYChart is the content of `@visx/xychart`
import { XYChart } from '@visx/visx';

() => (
  <XYChart.XYChart>
    <XYChart.LineSeries {...} />
  </XYChart.XYChart>
)

// or destructure like
import { XYChart as XYChartPackage } from '@visx/visx';
const { XYChart, LineSeries, ... } = XYChartPackage;

() => (
  <XYChart>
    <LineSeries {...} />
  </XYChart>
)

@kristw @hshoff
cc @valtism

@coveralls
Copy link

Pull Request Test Coverage Report for Build 532451544

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.749%

Totals Coverage Status
Change from base Build 516508911: 0.0%
Covered Lines: 1786
Relevant Lines: 2753

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@visx/xychart not available from @visx/visx package
3 participants