new(shape/Polygon): add optional 'points' override #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeisnt
changed the title
williaster
reviewed
Apr 13, 2021
There was a problem hiding this comment.
Hey @jakeisnt thanks for the contribution! 🙏 This seems like a useful override.
There are a few issues with the resulting TypeScript which shouldn't be too bad to fix.
williaster
changed the title
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
|
Should be good to go! Let me know if you'd like me to restructure the commits. |
williaster
approved these changes
Apr 15, 2021
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
pointsas a field to override its functionality for generating the points based on thesize,sidesandcenterprops. This allows users of the library to leverage the underlyingpolygon's flexibility while still making use of visx's styles and utilities.Note: If a
pointsprop is provided to a Polygon component, it's now used by the Polygon rather than being passed to the children.📝 Documentation
Polygoncomponent and provided a comment as documentation for it.