fix(scale): upgrade d3-time to v2.4 for d3-scale compatibility #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest minor version `3.3.0` of `d3-scale` makes use of utility functions exposed by `d3-time` version `2.1.0` (see: d3/d3-scale@80ff9b2#commitcomment-50668715) This makes `d3-scale` 3.3.* incompatible with `d3-time` `1.x` or even `2.0.0`
Pringels
commented
May 18, 2021
williaster
reviewed
May 18, 2021
There was a problem hiding this comment.
Thanks for the fix @Pringels 🙏 Bummer about the breaking minor version bump. I had one comment that hopefully will get the build working.
williaster
changed the title
williaster
approved these changes
May 19, 2021
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest minor version
3.3.0ofd3-scalemakes use of utility functions exposed byd3-timeversion2.1.0(see: d3/d3-scale@80ff9b2#commitcomment-50668715)This makes
d3-scale3.3.*incompatible withd3-time1.xor even2.0.0