Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zoom): fix provided zoom interface #1257

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

boy51
Copy link
Contributor

@boy51 boy51 commented Jun 29, 2021

🐛 Bug Fix

As a side note, I would really appreciate if we can add react@17 to the peer dependencies... Currently 17 is not included. I'm running production on 17 for a while and it works fine. With the latest changes in npm 7, there are many errors when trying to use with react 17 even though it works fine. Which is kinda sad considering most people trying to get into this lib are probably just installing react 17 thinking it doesn't work. If you guys are cool with it I can make PRs for this too.

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @boy51 ! This lgtm but had one comment about prettier.

Thanks for the nudge on React 17. We're planning internally for how to do this. I'll tag you on the open issue for that to coordinate if you'd like to help 🙏 Thanks again!

packages/visx-zoom/src/types.ts Outdated Show resolved Hide resolved
@boy51 boy51 force-pushed the master branch 2 times, most recently from 623b5c4 to 2ba2348 Compare July 1, 2021 08:05
@williaster
Copy link
Collaborator

thanks @boy51!

@williaster williaster merged commit 765832c into airbnb:master Jul 1, 2021
@github-actions
Copy link

github-actions bot commented Jul 1, 2021

🎉 This PR is included in version v1.14.1 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants