Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove @types/classnames #1281

Merged
merged 1 commit into from
Jul 20, 2021
Merged

fix: remove @types/classnames #1281

merged 1 commit into from
Jul 20, 2021

Conversation

Janpot
Copy link
Contributor

@Janpot Janpot commented Jul 18, 2021

🚀 Enhancements

noticed warnings during install

warning workspace-aggregator-d56295b5-e1bb-4287-aa1e-e72f5692b6cf > docs > @visx/xychart > @types/classnames@2.3.1: This is a stub types definition. classnames provides its own type definitions, so you do not need this installed.

Looks like classnames@>=2.3 comes with types

gazcn007
gazcn007 approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@gazcn007 gazcn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@williaster
Copy link
Collaborator

thanks for the fix @Janpot ! 🙏

@williaster williaster merged commit 60e9d6e into airbnb:master Jul 20, 2021
@github-actions
Copy link

🎉 This PR is included in version v1.17.1 of the packages modified 🎉

@Janpot Janpot deleted the classnames-2-3 branch July 20, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gazcn007 gazcn007 gazcn007 approved these changes

Assignees
No one assigned
Labels
🐛 bug patch-release 🤖 typescript @visx/annotation @visx/axis @visx/brush @visx/chord @visx/demo @visx/geo @visx/grid @visx/group @visx/heatmap @visx/hierarchy @visx/legend @visx/marker @visx/network @visx/pattern @visx/react-spring @visx/shape @visx/stats @visx/text @visx/tooltip @visx/voronoi @visx/xychart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @williaster @gazcn007