-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hierarchy comps #146
Conversation
</Group> | ||
); | ||
})} | ||
<Group top={top} left={left} className={className}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change this to
className={cx('vx-cluster', className)}
that way it has a default class and folks can add their own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got them both. I also found a (small) bug in my code, adding className where it has no business being 🐛
</Group> | ||
); | ||
})} | ||
<Group top={top} left={left} className={className}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
className={cx('vx-tree', className)}
I'll update the readme when this is merged (I need to have working links to the components). |
This is related to #139
This PR does the following (each statement applies to both
<Tree />
and<Cluster />
components:className
to each<Group />
component.className
prop should go? I didn't see any other reasonable place to put it.<DefaultLink />
and<DefaultNode />
components to each component, along with basic tests for each.This PR does not
size
,nodeSize
, andseparation
props.top
prop in either component--the prop gets passed to<Group />
which does have a default fortop
. So the default is set there (that's what I mean by "lowest level". I think this is the best way to do it.This is my first contribution to the codebase outside of documentation, so let me know if there's something I missed. For example, it doesn't have today's commits to master (I probably need to do that, right? 😬).