feat(xychart): add colorAccessor to LineSeries #1489
Conversation
Zenith00
changed the title
There was a problem hiding this comment.
Thanks for the addition @Zenith00 ! 🙌
This lgtm, I just merged a react@18 PR and want to test it as an alpha version. So once that's out we can publish this (should be later today if all goes well).
| <DataContext.Provider value={getDataContext(series)}> | ||
| <svg> | ||
| <LineSeries | ||
| dataKey={series.key} |
There was a problem hiding this comment.
looks like linting is complaining that this isn't a single line
<LineSeries dataKey={series.key} {...series} colorAccessor={(_) => 'banana'} />You could also run yarn format in the monorepo root, but sometimes that will update other files unintentionally (you can skip commit-ing them)
There was a problem hiding this comment.
yarn format run. Looks like it picked up a ,->; in BaseLineSeries as well
|
Awesome, thanks for the fix and again for the contributions! Should be released shortly 🎉 |
|
🎉 This PR is included in version |
|
Excited to see this update - thank you @Zenith00 ! |
🚀 Enhancements
resolves #1260
Based on #1005