new(react-spring): add tickLineProps to AnimatedTicks #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zenith00
changed the title
williaster
approved these changes
May 2, 2022
There was a problem hiding this comment.
lgtm, thanks for the contribution @Zenith00 🙏
will try to have this released later today (slight delay with react@18 support as mentioned on your other PR)
| @@ -10,7 +10,7 @@ export type AxisScaleOutput = number | NumberLike | undefined; | |||
| export type AxisScale<Output extends AxisScaleOutput = AxisScaleOutput> = | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| D3Scale<Output, any, any>; | |||
| type LineProps = Omit<React.SVGProps<SVGLineElement>, 'to' | 'from'>; | |||
| type LineProps = Omit<React.SVGProps<SVGLineElement>, 'to' | 'from' | 'ref'>; | |||
| @@ -101,4 +101,21 @@ describe('<BaseAxis />', () => { | |||
| expect(VisxLine).toHaveAttribute('stroke-width', `${axisStyles.axisLine.strokeWidth}`); | |||
| expect(VisxLine).toHaveAttribute('stroke', axisStyles.tickLine.stroke); | |||
| }); | |||
|
|
|||
| it('should accept props for tickline', () => { | |||
There was a problem hiding this comment.
thank you for adding tests! 🙏
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements