Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update deps for react-spring to specific target #1530

Merged
merged 1 commit into from
Jun 28, 2022
Merged

chore: Update deps for react-spring to specific target #1530

merged 1 commit into from
Jun 28, 2022

Conversation

ed-g-c
Copy link
Contributor

@ed-g-c ed-g-c commented Jun 27, 2022

🏠 Internal

  • Updates all dependencies on react-spring to the specific web target (@react-spring/web)
  • This follows recommended practice (see react-spring Getting Started)
  • This change also mitigates a critical vulnerability in the @react-spring/native dependency tree:
└─┬ react-spring@9.4.5
  └─┬ @react-spring/native@9.4.5
    └─┬ react-native@0.69.0
      └── hermes-engine@0.11.0

williaster
williaster approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @ed-g-c 🙏 lgtm, I'm going to pull it locally to test the demo page then we can land it 🚀

@williaster
Copy link
Collaborator

locally looks good 👍

@williaster williaster merged commit 0e5261a into airbnb:master Jun 28, 2022
@github-actions
Copy link

🎉 This PR is included in version v2.10.2 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏠 internal patch-release @visx/demo @visx/react-spring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ed-g-c @williaster