Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo/radar): uneven data elements renders spokes and web out of sync #1599

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

valMn
Copy link
Contributor

@valMn valMn commented Nov 15, 2022

🐛 Bug Fix

  • Update example code

Before
image
After
image

@valMn valMn changed the title fix uneven data elements renders spokes and wek out of sync fix(radar): uneven data elements renders spokes and web out of sync Nov 15, 2022
@valMn
Copy link
Contributor Author

valMn commented Nov 15, 2022

@williaster

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @studioVMdev ! 🙌 lgtm

@williaster
Copy link
Collaborator

noting that this doesn't actually affect the demo, but it would make it more generalizable to non-even number of input datum.

demo is unchanged:
image

@williaster williaster changed the title fix(radar): uneven data elements renders spokes and web out of sync fix(demo/radar): uneven data elements renders spokes and web out of sync Nov 16, 2022
@williaster williaster merged commit bd96c70 into airbnb:master Nov 16, 2022
@valMn valMn deleted the valentin-update-radar-chart-example branch November 17, 2022 09:24
@github-actions
Copy link

🎉 This PR is included in version v2.16.1 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants