fix(zoom): prevent wheel interfering with pinch #1639
Conversation
kiliancs
changed the title
Using a macbook, a touchpad pinch gesture will trigger `useGesture`'s pinch event, as desired, but it will also trigger the wheel event. Except in Safari. With this change, the wheel event handler bails if a pinch gesture is ongoing. Fixes: airbnb#1638
kiliancs
force-pushed
the
user/kilianc/fix_zoom_spasms
branch
from
5b16bb1 to
8551fcd
Compare
There was a problem hiding this comment.
Hey @kiliancs thanks so much for the bug report and digging in to fix this nuance 🙌 apologies for the review delay, have been absolutely slammed with work.
This lgtm but I think CI somehow didn't get triggered. Would it be possible for you to push another commit or rebase to trigger? if not I'm happy to do it since you already did the hard work 😅 thanks again
|
hey @kiliancs just wanted to ping you once more to see if you could rebase and push again to trigger CI. if not I'll do that tomorrow and land this. thanks again! |
|
Hi there! Sorry, I am currently on vacation and will probably not be able to get to it until next week, so if you don't mind going ahead with the rebase, that'd be great. |
|
🎉 This PR is included in version |
🐛 Bug Fix
Prevent wheel interfering with pinch
Using a macbook, a touchpad pinch gesture will trigger
useGesture's pinch event, as desired, but it will also trigger the wheel event. Except in Safari.With this change, the wheel event handler bails if a pinch gesture is ongoing.
Tested in Firefox, Chrome and Safari on a macbook.
Fixes: Zoom pinch spasming #1638