Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): fix missing API documentation #1648

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Feb 4, 2023

📝 Documentation

@williaster
Copy link
Collaborator

Hey @jonambas thanks so much for this fix! 🙏

Several other packages actually have the same issue right now, would you be interested in taking a shot at updating all of them? I think anything that's not importing from a <package>/src/* folder will have this issue, for example:

@jonambas
Copy link
Contributor Author

jonambas commented Feb 7, 2023

Sure thing! Will try take a look sometime this week

@jonambas jonambas changed the title fix(demo): fix missing visx/shape documentation fix(demo): fix missing API documentation Feb 11, 2023
@jonambas
Copy link
Contributor Author

@williaster Checked other pages, think I caught all of them.

Also fixed this small visual bug with the visx-point readme:

Screen Shot 2023-02-11 at 9 05 59 AM

After:

Screen Shot 2023-02-11 at 9 10 38 AM

Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonambas amazing, thanks so much for taking a pass at the other package docs 🙏

LGTM, will land once CI passes.

@williaster williaster merged commit af536db into airbnb:master Feb 13, 2023
@github-actions
Copy link

🎉 This PR is included in version v3.0.1 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visx/shape documentation missing
2 participants