Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tooltip): handle SSR in useTooltipInPortal #1672

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix(tooltip): handle SSR in useTooltipInPortal #1672

merged 2 commits into from
Mar 22, 2023

Conversation

korompaiistvan
Copy link
Contributor

💥 Breaking Changes

  • none

🚀 Enhancements

  • none per se

📝 Documentation

  • no API changes

🐛 Bug Fix

  • useTooltipInPortal relies on the window scroll position but that is not available on the server. these changes use a common method for detecting server side rendering

🏠 Internal

@korompaiistvan korompaiistvan marked this pull request as ready for review March 19, 2023 18:48
williaster
williaster approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, thanks for the fix @korompaiistvan ! 🙏

@williaster williaster changed the title fix SSR for useTooltipInPortal fix(tooltip): handle SSR in useTooltipInPortal Mar 22, 2023
@williaster williaster merged commit 590bbd2 into airbnb:master Mar 22, 2023
@github-actions
Copy link

🎉 This PR is included in version v3.1.2 of the packages modified 🎉

@korompaiistvan
Copy link
Contributor Author

apologies, I got swept away by life. thank you for the changes and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🐛 bug patch-release @visx/tooltip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korompaiistvan @williaster