Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glyph positioning in the xychart demo. #1730

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Fix glyph positioning in the xychart demo. #1730

merged 2 commits into from
Jul 10, 2023

Conversation

SheaJanke
Copy link
Contributor

🐛 Bug Fix

  • Fix the positioning of the non-animated glyph series in the xychart demo.

closes: #1715

@SheaJanke SheaJanke changed the title Fix xychart glyphs Fix glyph positioning in the xychart demo. Jul 7, 2023
williaster
williaster approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for digging in and fixing this @SheaJanke 🙌 lgtm 🚀

@williaster williaster merged commit 298b7bd into airbnb:master Jul 10, 2023
@github-actions
Copy link

🎉 This PR is included in version v3.3.0 of the packages modified 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🐛 bug @visx/demo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XYChart GlyphSeries glyphs appear at zero coordinate
2 participants
@SheaJanke @williaster