fix: radial bars demo import in CodeSandbox #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamzuch
changed the title
williaster
approved these changes
Jan 12, 2024
| @@ -4,7 +4,7 @@ import { Group } from '@visx/group'; | |||
| import { GradientLightgreenGreen } from '@visx/gradient'; | |||
| import { scaleBand, scaleRadial } from '@visx/scale'; | |||
| import { Text } from '@visx/text'; | |||
| import letterFrequency, { LetterFrequency } from '@visx/mock-data/src/mocks/letterFrequency'; | |||
| import letterFrequency, { LetterFrequency } from '@visx/mock-data/lib/mocks/letterFrequency'; | |||
There was a problem hiding this comment.
ah yes, sorry I didn't catch this. tricky to catch this one in CI as well.
| <GradientLightgreenGreen id="green" /> | ||
| <rect width={width} height={height} fill="url(#green)" rx={14} /> | ||
| <Group top={yMax / 2 + margin.top} left={xMax / 2}> | ||
| <GradientLightgreenGreen id="radial-bars-green" /> |
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
@visx/mock-datain the radial bars demo (feat(demo): add radial bars demo using Arc #1785) which was crashing when viewed in CodeSandbox. I must've used the autocompleted import from my editor and didn't notice.🚀 Enhancements