Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vx] fix all eslint errors + warnings, add missing propTypes. fixes #10 #371

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Oct 8, 2018

fixes: #10

💥 Breaking Changes

  • [vx] there's a possibility that new prop type checks might not be as care free as before

🚀 Enhancements

  • [vx] add missing propTypes to all components

🏠 Internal

  • [vx] add .eslintrc
  • [vx] fix all eslint errors + warnings

I'm turning off a number of eslint rules from the airbnb config to match the style of the codebase as of now. Not going to add the lint check to the test script for now. Will probably add it in the future.

@hshoff hshoff added this to the v0.0.179 milestone Oct 8, 2018
@hshoff hshoff merged commit b7a98e8 into master Oct 8, 2018
@hshoff hshoff deleted the harry-lint-fixing branch October 8, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prop types] add prop type checks to all components
1 participant